From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 16 May 2005 13:12:11 -0700 (PDT) From: christoph Subject: Re: [PATCH] Factor in buddy allocator alignment requirements in node memory alignment In-Reply-To: <1116277014.1005.113.camel@localhost> Message-ID: References: <1116274451.1005.106.camel@localhost> <1116276439.1005.110.camel@localhost> <1116277014.1005.113.camel@localhost> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Dave Hansen Cc: linux-mm , shai@scalex86.org, Linux Kernel Mailing List List-ID: On Mon, 16 May 2005, Dave Hansen wrote: > > > Do you know which pieces of code actually break if the alignment doesn't > > > meet what that warning says? > > > > I have seen nothing break but 4 MB allocations f.e. will not be allocated > > on a 4MB boundary with a 2 MB zone alignment. The page allocator always > > returnes properly aligned pages but 4MB allocations are an exception? > > I wasn't aware there was an alignment exception in the allocator for 4MB > pages. Could you provide some examples? I never said that there was an aligment exception. The special case for 4MB pages is created by the failure to properly align the zones in discontig.c. But may be that is okay? Then we just need to remove the lines that detect the misalignment in the page allocator. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org