From: Rik van Riel <riel@surriel.com>
To: "David S. Miller" <davem@davemloft.net>, Rik van Riel <riel@redhat.com>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC 1/3] non-resident page tracking
Date: Mon, 8 Aug 2005 16:30:17 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.61L.0508081628580.15038@imladris.surriel.com> (raw)
In-Reply-To: <20050808.132603.93023622.davem@davemloft.net>
On Mon, 8 Aug 2005, David S. Miller wrote:
> > @@ -359,7 +362,10 @@ struct page *read_swap_cache_async(swp_e
> > - lru_cache_add_active(new_page);
> > + if (activate >= 0)
> > + lru_cache_add_active(new_page);
> > + else
> > + lru_cache_add(new_page);
>
> This change is totally unrelated to the rest of the
> patch, and is not mentioned in the changelog. Could
> you explain it?
Oops, you're right. This is part of the replacement policy in
CLOCK-Pro, ARC, CART, etc. and should have been in a separate
patch.
This is what I get for pulling an all-nighter. ;)
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-08-08 20:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-08 20:14 [RFC 0/3] " Rik van Riel
2005-08-08 20:14 ` [RFC 1/3] " Rik van Riel
2005-08-08 20:26 ` David S. Miller, Rik van Riel
2005-08-08 20:30 ` Rik van Riel [this message]
2005-08-09 18:25 ` Marcelo Tosatti
2005-08-09 19:15 ` Peter Zijlstra
2005-08-09 21:13 ` Marcelo Tosatti
2005-08-10 8:40 ` Rik van Riel
2005-08-09 23:52 ` Rik van Riel
2005-08-08 20:14 ` [RFC 2/3] " Rik van Riel
2005-08-08 20:14 ` [RFC 3/3] " Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61L.0508081628580.15038@imladris.surriel.com \
--to=riel@surriel.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox