From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sat, 24 Mar 2007 01:06:28 +0100 (MET) From: Jan Engelhardt Subject: Re: [patch 1/2] hugetlb: add resv argument to hugetlb_file_setup In-Reply-To: Message-ID: References: <29495f1d0703231548k377e3f8ds5f2ae529c34e4380@mail.gmail.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Ken Chen Cc: Nish Aravamudan , Adam Litke , William Lee Irwin III , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Mar 23 2007 15:53, Ken Chen wrote: > > diff --git a/fs/hugetlbfs/inode.c b/fs/hugetlbfs/inode.c > index 8c718a3..981886f 100644 > --- a/fs/hugetlbfs/inode.c > +++ b/fs/hugetlbfs/inode.c > @@ -734,7 +734,7 @@ static int can_do_hugetlb_shm(void) > can_do_mlock()); > } > > -struct file *hugetlb_zero_setup(size_t size) > +struct file *hugetlb_file_setup(size_t size, int resv) > { > int error = -ENOMEM; > struct file *file; > @@ -771,7 +771,7 @@ struct file *hugetlb_zero_setup(size_t s > goto out_file; > > error = -ENOMEM; > - if (hugetlb_reserve_pages(inode, 0, size >> HPAGE_SHIFT)) > + if (resv && hugetlb_reserve_pages(inode, 0, size >> HPAGE_SHIFT)) > goto out_inode; > > d_instantiate(dentry, inode); Could not this be made a bool, then? Jan -- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org