Re: page_lock_anon_vma(): remove check for mapped page

[Hugh Dickins <hugh@veritas.com>]

On Mon, 27 Feb 2006, Christoph Lameter wrote:
> On Mon, 27 Feb 2006, Hugh Dickins wrote:
> 
> > > Or better do the rcu locking before calling page_lock_anon_vma 
> > > and the unlocking after spin_unlock to have proper nesting of locks?
> > 
> > No, page_lock_anon_vma is all about insulating the rest of the code
> > from these difficulties: I do prefer it as is.
> 
> Hmm... How about page_lock_anon_vma and page_unlock_anon_vma? This 
> 
> I fear that code reviewers will not realize that the freeing of the 
> anon_vma is in fact delayed much longer than a superficial review of the 
> page_lock_anon_vma reveals.
> 
> How about this patch:

I'd prefer not myself, perhaps someone else likes it.
And you haven't even based it on the check_mapped version you sent me,
which I then returned to you with more helpful comments.
Let's just move on?

Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>