From: Rik van Riel <riel@redhat.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH/RFT 2/5] CLOCK-Pro page replacement
Date: Wed, 10 Aug 2005 16:38:02 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.61.0508101637240.2695@chimarrao.boston.redhat.com> (raw)
In-Reply-To: <20050810.132744.18577541.davem@davemloft.net>
On Wed, 10 Aug 2005, David S. Miller wrote:
> From: Rik van Riel <riel@redhat.com>
> Date: Wed, 10 Aug 2005 16:02:18 -0400
>
> > --- linux-2.6.12-vm.orig/fs/proc/proc_misc.c
> > +++ linux-2.6.12-vm/fs/proc/proc_misc.c
> > @@ -219,6 +219,20 @@ static struct file_operations fragmentat
> > .release = seq_release,
> > };
> >
> > +extern struct seq_operations refaults_op;
>
> Please put this in linux/mm.h or similar, so that we'll get proper
> type checking of the definition in nonresident.c
The reason it is in fs/proc/proc_misc.c is that the rest of
these definitions are there.
I agree with you though, it would be a good thing if they
moved into a header file.
--
All Rights Reversed
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2005-08-10 20:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-10 20:02 [PATCH/RFT 0/5] " Rik van Riel
2005-08-10 20:02 ` [PATCH/RFT 1/5] " Rik van Riel
2005-08-10 20:02 ` [PATCH/RFT 2/5] " Rik van Riel
2005-08-10 20:27 ` David S. Miller, Rik van Riel
2005-08-10 20:38 ` Rik van Riel [this message]
2005-08-10 20:02 ` [PATCH/RFT 3/5] " Rik van Riel
2005-08-10 20:02 ` [PATCH/RFT 4/5] " Rik van Riel
2005-08-10 20:31 ` David S. Miller, Rik van Riel
2005-08-18 0:38 ` Andrew Morton
2005-08-18 2:48 ` David S. Miller, Andrew Morton
2005-08-18 4:05 ` Andrew Morton
2005-08-18 4:48 ` David S. Miller, Andrew Morton
2005-08-19 7:03 ` Rusty Russell
2005-08-19 7:10 ` Andrew Morton
2005-08-19 7:27 ` Rusty Russell
2005-08-19 13:04 ` Horst von Brand
2005-08-10 23:22 ` Marcelo Tosatti
2005-08-11 0:06 ` Rik van Riel
2005-08-10 20:02 ` [PATCH/RFT 5/5] " Rik van Riel
2005-08-11 22:08 ` Song Jiang
2005-08-12 1:22 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0508101637240.2695@chimarrao.boston.redhat.com \
--to=riel@redhat.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox