From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 25 Jul 2005 13:39:29 +0100 (BST) From: Hugh Dickins Subject: Re: PageReserved removal from swsusp In-Reply-To: <42E4852D.7010209@yahoo.com.au> Message-ID: References: <42E44294.5020408@yahoo.com.au> <1122265909.6144.106.camel@localhost> <42E46FF5.5080805@yahoo.com.au> <42E4852D.7010209@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: ncunningham@cyclades.com, Linux Memory Management , Pavel Machek , William Lee Irwin III List-ID: On Mon, 25 Jul 2005, Nick Piggin wrote: > > However I'm not sure that I really like the use of > flags == 0xffffffff to indicate the page is unusable. For one thing it > may confuse things that walk physical pages, and for another it can > easily break if someone clears a flag of an 'unusable' page. I don't like that either. Setting all the flags seems to maximize the chance of error somewhere. Perhaps a magic number in one of the other struct page fields would work more safely. Or perhaps just leave it as its own flag bit for now, and later go on a separate free-up-some- flags exercise. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org