From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 16 May 2005 23:34:55 +0000 (UTC) From: Michal Ludvig Subject: [PATCH] fix for mm counters to macros conversion Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Christoph Lameter Cc: Andrew Morton , linux-mm@kvack.org List-ID: Hi, The patch of Christoph Lameter sent on March 15 contains this in mm/rmap.c:try_to_unmap_one() around line 590: - mm->rss--; + inc_mm_counter(mm, rss); I wonder if it was an intent to change dec to inc? In all other places the conversion conforms to the previous operation except for this one. Perhaps the following patch should be applied... Signed-off-by: Michal Ludvig Index: linux-2.6.12-rc4/mm/rmap.c =================================================================== --- linux-2.6.12-rc4.orig/mm/rmap.c 2005-05-07 17:20:31.000000000 +1200 +++ linux-2.6.12-rc4/mm/rmap.c 2005-05-17 11:16:40.716223000 +1200 @@ -586,7 +586,7 @@ dec_mm_counter(mm, anon_rss); } - inc_mm_counter(mm, rss); + dec_mm_counter(mm, rss); page_remove_rmap(page); page_cache_release(page); Michal Ludvig -- * Personal homepage - http://www.logix.cz/michal -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org