From: Mel Gorman <mel@csn.ul.ie>
To: akpm@osdl.org
Cc: Linux Memory Management List <linux-mm@kvack.org>
Subject: [PATCH] Compile error on x86 with hotplug but no highmem
Date: Fri, 27 Jan 2006 10:17:49 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.58.0601271014090.25836@skynet> (raw)
Memory hotplug without highmem is meaningless but it is still an allowed
configuration. This is one possible fix. Another is to not allow memory
hotplug without high memory being available. Another is to take
online_page() outside of the #ifdef CONFIG_HIGHMEM block in init.c .
Signed-off-by: Mel Gorman <mel@csn.ul.ie>
diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.16-rc1-mm3-clean/arch/i386/mm/init.c linux-2.6.16-rc1-mm3-nohighmemhotplug/arch/i386/mm/init.c
--- linux-2.6.16-rc1-mm3-clean/arch/i386/mm/init.c 2006-01-25 13:42:41.000000000 +0000
+++ linux-2.6.16-rc1-mm3-nohighmemhotplug/arch/i386/mm/init.c 2006-01-27 10:10:26.000000000 +0000
@@ -324,6 +324,7 @@ static void __init set_highmem_pages_ini
#define kmap_init() do { } while (0)
#define permanent_kmaps_init(pgd_base) do { } while (0)
#define set_highmem_pages_init(bad_ppro) do { } while (0)
+void online_page(struct page *page) {}
#endif /* CONFIG_HIGHMEM */
unsigned long long __PAGE_KERNEL = _PAGE_KERNEL;
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next reply other threads:[~2006-01-27 10:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-27 10:17 Mel Gorman [this message]
2006-01-27 20:02 ` Dave Hansen
2006-01-29 15:59 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58.0601271014090.25836@skynet \
--to=mel@csn.ul.ie \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox