From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 22 Nov 2005 11:10:58 +0000 (GMT) From: Mel Gorman Subject: Re: [PATCH 2/5] Light Fragmentation Avoidance V20: 002_usemap In-Reply-To: <4382F8DD.9090908@jp.fujitsu.com> Message-ID: References: <20051115164946.21980.2026.sendpatchset@skynet.csn.ul.ie> <200511160036.54461.ak@suse.de> <200511160252.05494.ak@suse.de> <4382EF48.1050107@shadowen.org> <20051122102237.GK20775@brahms.suse.de> <4382F8DD.9090908@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: KAMEZAWA Hiroyuki Cc: Andi Kleen , Andy Whitcroft , linux-mm@kvack.org, mingo@elte.hu, lhms-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, nickpiggin@yahoo.com.au List-ID: On Tue, 22 Nov 2005, KAMEZAWA Hiroyuki wrote: > Mel Gorman wrote: > > > #define PG_checked 8 /* kill me in 2.5.. */ > > > > > > ? > > > > > > At least PG_uncached isn't used on many architectures too, so could > > > be reused. I don't know why those that use it don't check VMAs instead. > > > > > > > > > PG_unchecked appears to be totally unused. It's only users are the macros > > that manipulate the bit and mm/page_alloc.c . It appears it has been a > > long time since it was used to it is a canditate for reuse. > > > > Just a notification.. > from 2.6.14 > > PageUncached 375 include/asm-ia64/uaccess.h if (PageUncached(page)) > PageUncached 393 include/asm-ia64/uaccess.h if (PageUncached(page)) > > This is used by /dev/mem > > > PageChecked 196 fs/afs/dir.c if (!PageChecked(page)) > PageChecked 169 fs/ext2/dir.c if (!PageChecked(page)) > PageChecked 1372 fs/ext3/inode.c if (!page_has_buffers(page) || > PageChecked(page)) { > PageChecked 1441 fs/ext3/inode.c WARN_ON(PageChecked(page)); > PageChecked 2350 fs/reiserfs/inode.c int checked = > PageChecked(page); > PageChecked 2853 fs/reiserfs/inode.c WARN_ON(PageChecked(page)); > > This is used by fs, now. > d'oh. I was looking for the flags, not the macros :( -- Mel Gorman Part-time Phd Student Java Applications Developer University of Limerick IBM Dublin Software Lab -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org