From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 4 Aug 2005 08:36:09 -0700 (PDT) From: Linus Torvalds Subject: Re: [patch 2.6.13-rc4] fix get_user_pages bug In-Reply-To: <20050804150053.GA1346@localhost.localdomain> Message-ID: References: <42F09B41.3050409@yahoo.com.au> <20050804141457.GA1178@localhost.localdomain> <42F2266F.30008@yahoo.com.au> <20050804150053.GA1346@localhost.localdomain> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Alexander Nyberg Cc: Nick Piggin , Hugh Dickins , Martin Schwidefsky , Andrew Morton , Robin Holt , linux-kernel , linux-mm@kvack.org, Ingo Molnar , Roland McGrath , Andi Kleen List-ID: On Thu, 4 Aug 2005, Alexander Nyberg wrote: > > Hardcoding is evil so it's good it gets cleaned up anyway. Yes. > > parisc, cris, m68k, frv, sh64, arm26 are also broken. Would you mind > > resending a patch that fixes them all? > > Remove the hardcoding in return value checking of handle_mm_fault() I only saw this one when I had already done it myself. Your arm26 conversion was only partial, btw. Notice how it returns the fault number (with a few extensions of its own) and processes it further? I think I got that right. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org