From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 3 Aug 2005 09:39:03 -0700 (PDT) From: Linus Torvalds Subject: Re: [patch 2.6.13-rc4] fix get_user_pages bug In-Reply-To: Message-ID: References: <42F09B41.3050409@yahoo.com.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Nick Piggin Cc: Hugh Dickins , Martin Schwidefsky , Andrew Morton , Robin Holt , linux-kernel , linux-mm@kvack.org, Ingo Molnar , Roland McGrath List-ID: On Wed, 3 Aug 2005, Linus Torvalds wrote: > > Ok, I applied this because it was reasonably pretty and I liked the > approach. It seems buggy, though, since it was using "switch ()" to test > the bits (wrongly, afaik), and I'm going to apply the appended on top of > it. Holler quickly if you disagreee.. Another problem I just thought of. What about PROT_NONE pages? Afaik, they have _exactly_ the same issue on the read side as a PROT_READ page has on the write side: pte_read() may fail on them. What makes us not get into an infinite loop there? Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org