From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 2 Aug 2005 11:47:59 -0700 (PDT) From: Linus Torvalds Subject: Re: [patch 2.6.13-rc4] fix get_user_pages bug In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Martin Schwidefsky , Andrew Morton , Robin Holt , linux-kernel , linux-mm@kvack.org, Ingo Molnar , Nick Piggin , Roland McGrath List-ID: On Tue, 2 Aug 2005, Hugh Dickins wrote: > > It might not be so bad. It's going to access the struct page anyway. > And clearing dirty from parent and child at fork time could save two > set_page_dirtys at exit time. But I'm not sure that we could batch the > the dirty bit clearing into one TLB flush like we do the write protection. Yes, good point. If the thing is still marked dirty in the TLB, some other thread might be writing to the page after we've cleared dirty but before we've flushed the TLB - causing the new dirty bit to be lost. I think. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org