From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 18 May 2005 19:47:57 -0700 (PDT) From: Linus Torvalds Subject: Re: [PATCH] prevent NULL mmap in topdown model In-Reply-To: Message-ID: References: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Rik van Riel Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Wed, 18 May 2005, Rik van Riel wrote: > > On Wed, 18 May 2005, Linus Torvalds wrote: > > > Why not just change the "addr >= len" test into "addr > len" and be done > > with it? > > If you're fine with not catching dereferences of a struct > member further than PAGE_SIZE into a struct when the struct > pointer is NULL, sure ... I'm certainly ok with that, especially since it should never be a problem in practice (ie the virtual memory map getting so full that we even get to these low allocations should be basically something that never happens under normal load). However, it would be good to have even the trivial patch tested. Especially since what it tries to fix is a total corner-case in the first place.. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org