From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 4 Feb 2004 18:47:42 -0800 (PST) From: Linus Torvalds Subject: Re: [Bugme-new] [Bug 2019] New: Bug from the mm subsystem involving X (fwd) In-Reply-To: <1075948401.13163.19077.camel@dyn318004bld.beaverton.ibm.com> Message-ID: References: <51080000.1075936626@flay> <60330000.1075939958@flay> <64260000.1075941399@flay> <20040204165620.3d608798.akpm@osdl.org> <1075946211.13163.18962.camel@dyn318004bld.beaverton.ibm.com> <1075948401.13163.19077.camel@dyn318004bld.beaverton.ibm.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Keith Mannthey Cc: Andrew Morton , "Martin J. Bligh" , "linux-kernel@vger.kernel.org" , linux-mm@kvack.org List-ID: On Wed, 4 Feb 2004, Keith Mannthey wrote: > > I tried Andrews VM_IO patch earlier today but it didn't fix the > problem. Yeah, that patch is not actually converting the pfn_valid() users to only trust VM_IO, it only does a few special cases (notably the follow_pages() thing, which wasn't the issue here). So the patch would have to be expanded to cover _all_ of the page table following functions. It probably isn't that much, just looking for code that checks for PageReserved() will pinpoint the needed users pretty well. So I think the VM_IO approach could fix this, but it would need to be fleshed out more. In the meantime, fixing pfn_valid() is definitely the right thing to do. Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org