From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 4 Feb 2004 16:43:03 -0800 (PST) From: Linus Torvalds Subject: Re: [Bugme-new] [Bug 2019] New: Bug from the mm subsystem involving X (fwd) In-Reply-To: <64260000.1075941399@flay> Message-ID: References: <51080000.1075936626@flay> <60330000.1075939958@flay> <64260000.1075941399@flay> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: "Martin J. Bligh" Cc: linux-kernel , linux-mm mailing list , kmannth@us.ibm.com, Andrew Morton List-ID: On Wed, 4 Feb 2004, Martin J. Bligh wrote: > > Oh hell ... I remember what's wrong with this whole bit. pfn_valid is > used inconsistently in different places, IIRC. Linus / Andrew ... what > do you actually want it to mean? Some things seem to use it to say > "the memory here is valid accessible RAM", some things "there is a > valid struct page for this pfn". I was aiming for the latter, but a > few other arches seemed to disagree. > > Could I get a ruling on this? ;-) It _definitely_ means "there is a valid 'struct page' for this pfn". To test for "there is RAM" here, you need to first check that the pfn is valid, and then you can check what the page type is (usually that would be PageReserved(), but it could be a highmem check or something like that too). Linus -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org