From: Anand Eswaran <aeswaran@andrew.cmu.edu>
To: "Raghu R. Arur" <rra2002@cs.columbia.edu>
Cc: linux-mm@kvack.org
Subject: Re: writepage
Date: Mon, 1 Mar 2004 15:59:11 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.58-035.0403011555590.2281@unix43.andrew.cmu.edu> (raw)
In-Reply-To: <Pine.LNX.4.44.0403011531260.32137-100000@delhi.clic.cs.columbia.edu>
In that case, it seems to me that during the next pass of the launder
loop, the loop by definition cannot have a (page->mapping) value of NULL
because it has been added to the swapcache in the previous pass.
Is that true?
-----
Anand.
On Mon, 1 Mar 2004, Raghu R. Arur wrote:
>
> The page is added to the swap cache by add_to_swap_cache and not by
> writepage.
>
> writepage() (swap_writepage() in this case) prepares the page to write to
> the swap disk by creating buffers and submits the page to the disk. So
> page->buffers will be NON_NULL.
>
> Raghu.
>
> On Mon, 1 Mar 2004, Anand Eswaran wrote:
>
> > Hi :
> >
> > I have quick question reg Linux 2.4.18, Ive tried to understand the code
> > but am pretty confused:
> >
> > In the typical malloc execution-path, the page is added to swap and it's
> > pte_chain is unmapped after which the writepage() is executed. However I
> > notice that *after* the writepage(), the page->buffers is NON_NULL.
> >
> > Is this supposed to happen? I thought the writepage function flushed the
> > page to swap, so why are there residual buffers?
> >
> > Thanks,
> > ----
> > Anand.
> >
> > --
> > To unsubscribe, send a message with 'unsubscribe linux-mm' in
> > the body to majordomo@kvack.org. For more info on Linux MM,
> > see: http://www.linux-mm.org/ .
> > Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
> >
>
>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-03-01 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-01 20:27 writepage Anand Eswaran
2004-03-01 20:33 ` writepage Raghu R. Arur
2004-03-01 20:59 ` Anand Eswaran [this message]
2004-03-01 21:05 ` writepage Anand Eswaran
2004-03-01 21:10 ` writepage Raghu R. Arur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.58-035.0403011555590.2281@unix43.andrew.cmu.edu \
--to=aeswaran@andrew.cmu.edu \
--cc=linux-mm@kvack.org \
--cc=rra2002@cs.columbia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox