From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx156.postini.com [74.125.245.156]) by kanga.kvack.org (Postfix) with SMTP id 22E9C6B005A for ; Mon, 22 Oct 2012 15:18:31 -0400 (EDT) Date: Mon, 22 Oct 2012 15:18:29 -0400 (EDT) From: Alan Stern Subject: Re: [RFC PATCH v2 4/6] net/core: apply pm_runtime_set_memalloc_noio on network devices In-Reply-To: <1350894794-1494-5-git-send-email-ming.lei@canonical.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org List-ID: To: Ming Lei Cc: linux-kernel@vger.kernel.org, Oliver Neukum , Minchan Kim , Greg Kroah-Hartman , "Rafael J. Wysocki" , Jens Axboe , "David S. Miller" , Andrew Morton , netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, linux-mm@kvack.org, Eric Dumazet , David Decotigny , Tom Herbert , Ingo Molnar On Mon, 22 Oct 2012, Ming Lei wrote: > Deadlock might be caused by allocating memory with GFP_KERNEL in > runtime_resume callback of network devices in iSCSI situation, so > mark network devices and its ancestor as 'memalloc_noio_resume' > with the introduced pm_runtime_set_memalloc_noio(). Is this really needed? Even with iSCSI, doesn't register_disk() have to be called for the underlying block device? And given your 3/6 patch, wouldn't that mark the network device? Alan Stern -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org