From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 6 Mar 2002 15:09:29 -0300 (BRT) From: Rik van Riel Subject: Re: [PATCH] struct page shrinkage In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Bulent Abali Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Wed, 6 Mar 2002, Bulent Abali wrote: > >Rik van Riel wrote: > >> > >> + clear_bit(PG_locked, &p->flags); > > > >Please don't do this. Please use the macros. If they're not > >there, please create them. > > > >Bypassing the abstractions in this manner confounds people > >who are implementing global locked-page accounting. > > I have an application which needs to know the total number of locked and > dirtied pages at any given time. In which application locked-page > accounting is done? I don't see it in base 2.5.5. Are there any patches > or such that you can give pointers to? You could modify lock_page to do statistics. This is made easier if you are sure that every driver uses lock_page / LockPage and UnlockPage I'm happy Andrew made me clean up the drivers instead of just fixing them ;) regards, Rik -- "Linux holds advantages over the single-vendor commercial OS" -- Microsoft's "Competing with Linux" document http://www.surriel.com/ http://distro.conectiva.com/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/