From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Nikita Danilov <nikita@clusterfs.com>,
Linux-Kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH]: 3/4 mm/rmap.c cleanup
Date: Mon, 22 Nov 2004 14:31:02 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.44.0411221428080.2867-100000@localhost.localdomain> (raw)
In-Reply-To: <20041121131437.4c3bcee0.akpm@osdl.org>
On Sun, 21 Nov 2004, Andrew Morton wrote:
> Nikita Danilov <nikita@clusterfs.com> wrote:
> >
> > mm/rmap.c:page_referenced_one() and mm/rmap.c:try_to_unmap_one() contain
> > identical code that
> >
> > - takes mm->page_table_lock;
> >
> > - drills through page tables;
> >
> > - checks that correct pte is reached.
> >
> > Coalesce this into page_check_address()
>
> Looks sane, but it comes at a bad time. Please rework and resubmit after
> the 4-level pagetable code is merged into Linus's tree, post-2.6.10.
Personally, I prefer the straightforward way it looks without Nikita's
patch. But it is a matter of personal taste, and I may well be in the
minority.
Would be better justified if the common function were not "inline"?
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2004-11-22 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 15:44 Nikita Danilov
[not found] ` <m1zn1bmbu3.fsf@clusterfs.com>
2004-11-21 16:14 ` Nikita Danilov
2004-11-21 21:14 ` Andrew Morton
2004-11-22 14:31 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0411221428080.2867-100000@localhost.localdomain \
--to=hugh@veritas.com \
--cc=Linux-Kernel@vger.kernel.org \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox