From: Hugh Dickins <hugh@veritas.com>
To: Nikita Danilov <nikita@clusterfs.com>
Cc: Andrew Morton <akpm@osdl.org>,
Linux-Kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH]: 2/4 mm/swap.c cleanup
Date: Mon, 22 Nov 2004 14:27:10 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.44.0411221419100.2867-100000@localhost.localdomain> (raw)
In-Reply-To: <16801.6313.996546.52706@gargle.gargle.HOWL>
On Mon, 22 Nov 2004, Nikita Danilov wrote:
> Andrew Morton writes:
> >
> > Sorry, this looks more like a dirtyup to me ;)
>
> Don't tell me you are not great fan on comma operator abuse. :)
>
> Anyway, idea is that by hiding complexity it loop macro, we get rid of a
> maze of pvec-loops in swap.c all alike.
>
> Attached is next, more typeful variant. Compilebootentested.
You're scaring me, Nikita. Those loops in mm/swap.c are easy to follow,
whyever do you want to obfuscate them with your own macro maze?
Ingenious for_each macros make sense where it's an idiom which is going
to be useful to many across the tree; but these are just a few instances
in a single source file.
Please find a better outlet for your talents!
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-11-22 14:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-11-21 15:44 Nikita Danilov
2004-11-21 21:13 ` Andrew Morton
2004-11-21 22:37 ` Nikita Danilov
2004-11-22 14:27 ` Hugh Dickins [this message]
2004-11-22 15:50 ` Nikita Danilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0411221419100.2867-100000@localhost.localdomain \
--to=hugh@veritas.com \
--cc=Linux-Kernel@vger.kernel.org \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=nikita@clusterfs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox