linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Hugh Dickins <hugh@veritas.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andi Kleen <ak@suse.de>, Linux Memory Management <linux-mm@kvack.org>
Subject: Re: [RFC] Possible alternate 4 level pagetables?
Date: Mon, 15 Nov 2004 21:37:45 +0000 (GMT)	[thread overview]
Message-ID: <Pine.LNX.4.44.0411152121340.4171-100000@localhost.localdomain> (raw)
In-Reply-To: <4196F12D.20005@yahoo.com.au>

On Sun, 14 Nov 2004, Nick Piggin wrote:
> 
> Just looking at your 4 level page tables patch, I wondered why the extra
> level isn't inserted between pgd and pmd, as that would appear to be the
> least intrusive (conceptually, in the generic code). Also it maybe matches
> more closely the way that the 2->3 level conversion was done.

I thought the same, when I finally took a look a week or so ago.

I've scarcely looked at your patches, but notice they change i386.

For me, the attraction of putting the new level in between pgd and pmd
was that it seemed that only common code and x86_64 (and whatever else
comes to use all four levels in future) would need changing (beyond,
perhaps, #including some asm-generic headers).  Some casting to combine
the two levels into pmd in unchanged arch code, or rename pmd to pld in
the changed common code.  Andi's arch patches seemed (all?) to spring
from replacing mm->pgd by mm->pml4.

But I could well be mistaken, I wasn't so industrious as to actually
try it.

> I've been toying with it a little bit. It is mainly just starting with
> your code and doing straight conversions, although I also attempted to
> implement a better compatibility layer that does the pagetable "folding"
> for you if you don't need to use the full range of them.
> 
> Caveats are that there is still something slightly broken with it on i386,
> and so I haven't looked at x86-64 yet. I don't see why this wouldn't work
> though.
> 
> I've called the new level 'pud'. u for upper or something.

Well, yes, your base appetites have led you to the name "pud",
where my refined intellect led me to "phd", with h for higher ;)

> Sorry the patch isn't in very good shape at the moment - I won't have time
> to work on it for a week, so I thought this would be a good point just to
> solicit initial comments.

I doubt it's worthwhile now, particularly if you do have to patch arches.

Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>

  parent reply	other threads:[~2004-11-15 21:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-11-14  5:46 Nick Piggin
2004-11-14  5:46 ` Nick Piggin
2004-11-14  5:47   ` Nick Piggin
2004-11-14  5:48     ` Nick Piggin
2004-11-14  5:50       ` Nick Piggin
2004-11-14  8:25 ` Andi Kleen
2004-11-15  1:19   ` Nick Piggin
2004-11-15 21:37 ` Hugh Dickins [this message]
2004-11-16  1:11   ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.44.0411152121340.4171-100000@localhost.localdomain \
    --to=hugh@veritas.com \
    --cc=ak@suse.de \
    --cc=linux-mm@kvack.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox