From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sun, 24 Oct 2004 16:37:47 +0100 (BST) From: Hugh Dickins Subject: Re: [PATCH] Migration cache In-Reply-To: <20041024122133.GA17762@logos.cnet> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: owner-linux-mm@kvack.org Return-Path: To: Marcelo Tosatti Cc: Hirokazu Takahashi , haveblue@us.ibm.com, iwamoto@valinux.co.jp, kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org List-ID: On Sun, 24 Oct 2004, Marcelo Tosatti wrote: > > BTW, while I was reading the code, I wondered: > > struct swap_info_struct swap_info[MAX_SWAPFILES]; > > This array should be created dynamically. Worth > the trouble? It is rather primitive, but I don't think it's worth the trouble to change it on its own - certainly not worth changing it to allocate the full array at runtime, and if you changed it to allocate slot by slot then quite a few places (within swapfile.c) would need changing. I can imagine someone doing a big cleanup of swapfile.c in which that static array vanished, but I don't think it's worth doing on its own. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org