From: Hugh Dickins <hugh@veritas.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: Hirokazu Takahashi <taka@valinux.co.jp>,
haveblue@us.ibm.com, iwamoto@valinux.co.jp,
kamezawa.hiroyu@jp.fujitsu.com, linux-mm@kvack.org
Subject: Re: [PATCH] Migration cache
Date: Sun, 24 Oct 2004 16:37:47 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.44.0410241633530.12020-100000@localhost.localdomain> (raw)
In-Reply-To: <20041024122133.GA17762@logos.cnet>
On Sun, 24 Oct 2004, Marcelo Tosatti wrote:
>
> BTW, while I was reading the code, I wondered:
>
> struct swap_info_struct swap_info[MAX_SWAPFILES];
>
> This array should be created dynamically. Worth
> the trouble?
It is rather primitive, but I don't think it's worth the trouble to
change it on its own - certainly not worth changing it to allocate
the full array at runtime, and if you changed it to allocate slot by
slot then quite a few places (within swapfile.c) would need changing.
I can imagine someone doing a big cleanup of swapfile.c in which that
static array vanished, but I don't think it's worth doing on its own.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2004-10-24 15:37 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-14 19:22 Marcelo Tosatti
2004-10-18 16:57 ` Hirokazu Takahashi
2004-10-20 17:10 ` Hirokazu Takahashi
2004-10-21 10:30 ` Marcelo Tosatti
2004-10-21 19:09 ` Hugh Dickins
2004-10-21 18:22 ` Marcelo Tosatti
2004-10-22 6:49 ` Hirokazu Takahashi
2004-10-23 19:28 ` Marcelo Tosatti
2004-10-23 22:26 ` Hugh Dickins
2004-10-24 12:21 ` Marcelo Tosatti
2004-10-24 15:37 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0410241633530.12020-100000@localhost.localdomain \
--to=hugh@veritas.com \
--cc=haveblue@us.ibm.com \
--cc=iwamoto@valinux.co.jp \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=taka@valinux.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox