From: Hugh Dickins <hugh@veritas.com>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-mm@kvack.org, akpm@osdl.org
Subject: Re: [PATCH] use find_trylock_page in free_swap_and_cache instead of hand coding
Date: Fri, 15 Oct 2004 14:20:08 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.44.0410151411330.5770-100000@localhost.localdomain> (raw)
In-Reply-To: <20041015104502.GA1989@logos.cnet>
On Fri, 15 Oct 2004, Marcelo Tosatti wrote:
>
> This small cleanup to free_swap_and_cache() substitues a
> "lock - radix lookup - TestSetPageLocked - unlock" sequence
> of instructions with "find_trylock_page()" (which does
> exactly that).
You're right: I must have been so excited by distinguishing the swapcache
from the pagecache, that I was blind to how that was still applicable
(unlike inserting and removing).
But please extend your patch to mm/swap_state.c, where you can get rid
of the two radix_tree_lookups by reverting to find_get_page - thanks!
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2004-10-15 13:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-15 10:45 Marcelo Tosatti
2004-10-15 13:20 ` Hugh Dickins [this message]
2004-10-15 18:35 ` Marcelo Tosatti
2004-10-15 21:54 ` Hugh Dickins
2004-10-15 21:09 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0410151411330.5770-100000@localhost.localdomain \
--to=hugh@veritas.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox