From: Rik van Riel <riel@redhat.com>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: Andrew Morton <akpm@osdl.org>, linux-mm@kvack.org
Subject: Re: [PATCH] 1/4: rework alloc_pages
Date: Fri, 6 Aug 2004 08:01:43 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.44.0408060759550.8229-100000@dhcp83-102.boston.redhat.com> (raw)
In-Reply-To: <41131FA6.4070402@yahoo.com.au>
On Fri, 6 Aug 2004, Nick Piggin wrote:
> for_each_zone(z) {
> if (z->free_pages < z->pages_low + z->protection)
> continue;
> else
> goto got_pg;
> }
>
> for_each_zone(z)
> wakeup_kswapd(z);
Note that since kswapd does NOT take z->protection into account,
you could end up doing too much asynchronous page recycling from
the highmem zone while having stale pages sitting around in the
normal zone.
As long as we have the lowmem protection switched off by default
we should be fine, though. Either that, or wakeup_kswapd should
tell kswapd what the threshold is ...
--
"Debugging is twice as hard as writing the code in the first place.
Therefore, if you write the code as cleverly as possible, you are,
by definition, not smart enough to debug it." - Brian W. Kernighan
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
prev parent reply other threads:[~2004-08-06 12:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-06 4:57 Nick Piggin
2004-08-06 4:57 ` [PATCH] 2/4: highmem watermarks Nick Piggin
2004-08-06 5:03 ` [PATCH] 3/4: writeout watermarks Nick Piggin
2004-08-06 5:04 ` [PATCH] 4/4: incremental min aware kswapd Nick Piggin
2004-08-06 5:27 ` [PATCH] 3/4: writeout watermarks Andrew Morton
2004-08-06 5:34 ` Nick Piggin
2004-08-06 5:49 ` Andrew Morton
2004-08-06 6:13 ` Nick Piggin
2004-08-06 6:19 ` Andrew Morton
2004-08-06 6:36 ` Nick Piggin
2004-08-06 5:12 ` [PATCH] 1/4: rework alloc_pages Nick Piggin
2004-08-06 5:19 ` Andrew Morton
2004-08-06 5:29 ` Nick Piggin
2004-08-06 5:37 ` Andrew Morton
2004-08-06 6:05 ` Nick Piggin
2004-08-06 6:17 ` Andrew Morton
2004-08-06 12:01 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0408060759550.8229-100000@dhcp83-102.boston.redhat.com \
--to=riel@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-mm@kvack.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox