Re: [PATCH] /dev/zero page fault scaling

[Hugh Dickins <hugh@veritas.com>]

On Thu, 15 Jul 2004, Brent Casavant wrote:
> On Thu, 15 Jul 2004, Hugh Dickins wrote:
> 
> > +	/* Keep it simple: disallow limited <-> unlimited remount */
> > +	if ((max_blocks || max_inodes) == !sbinfo)
> > +		return -EINVAL;
> 
> Just caught this one.
> 
> Shouldn't this be:
> 
> 	if ((max_blocks || max_inodes) && !sbinfo)
> 		return -EINVAL;

That's only one half of what I'm trying to disable there, certainly
the more justifiable half, unlimited -> limited.  At the same time
I'm trying to say

	if (!(max_blocks || max_inodes) && sbinfo)
		return -EINVAL;

that is, also disable limited -> unlimited.  Why?  To save bloating
the code, really.  If that's allowed then (a) we need to add in
kfreeing the old sbinfo and (b) we ought really to go through the
existing inodes changing i_blocks (maintained while sbinfo) to 0
(as always while !sbinfo).  Not worth the bother, I thought.

Hugh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>