From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Thu, 1 Apr 2004 06:05:47 +0100 (BST) From: Hugh Dickins Subject: Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix In-Reply-To: <20040401020126.GW2143@dualathlon.random> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: owner-linux-mm@kvack.org Return-Path: To: Andrea Arcangeli Cc: Andrew Morton , vrajesh@umich.edu, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Thu, 1 Apr 2004, Andrea Arcangeli wrote: > On Wed, Mar 31, 2004 at 05:51:13PM -0800, Andrew Morton wrote: > > rw_swap_page_sync() is a general-purpose library function and we shouldn't > > be making assumptions about the type of page which the caller happens to be > > feeding us. > > that is a specialized backdoor to do I/O on _private_ pages, it's not a > general-purpose library function for doing anonymous pages I'm not against anal checks (except personally :), but I'm very much with Andrea on this: rw_swap_page_sync is horrid, but does manage to do a particular job. The header page is great fun: sys_swapon and mkswap read and write it by a totally different route, I shudder (especially when it's a swapfile with blocksize less than pagesize). It would be nice to make it more general and correct, but that's not something you should get stuck on right now. Hugh -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org