From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sun, 21 Mar 2004 21:32:46 -0500 (EST) From: Rik van Riel Subject: Re: [RFC][PATCH 1/3] radix priority search tree - objrmap complexity fix In-Reply-To: <20040322004652.GF3649@dualathlon.random> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Andrea Arcangeli Cc: Rajesh Venkatasubramanian , akpm@osdl.org, torvalds@osdl.org, hugh@veritas.com, mbligh@aracnet.com, mingo@elte.hu, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Mon, 22 Mar 2004, Andrea Arcangeli wrote: > It would be curious to test it after changing the return 1 to return 0 > in the page_referenced trylock failures? In the case of a trylock failure, it should probably return a random value. For heavily page faulting multithreaded apps, that would mean we'd tend towards random replacement, instead of FIFO. Then again, the locking problems shouldn't be too bad in most cases. If you're swapping the program will be waiting on IO and if it's not waiting on IO there's no problem. -- "Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it." - Brian W. Kernighan -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: aart@kvack.org