From: Hugh Dickins <hugh@veritas.com>
To: "Paul E. McKenney" <paulmck@us.ibm.com>
Cc: phillips@arcor.de, akpm@digeo.com, hch@infradead.org,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH] Avoid vmtruncate/mmap-page-fault race
Date: Thu, 29 May 2003 17:33:04 +0100 (BST) [thread overview]
Message-ID: <Pine.LNX.4.44.0305291723310.1800-100000@localhost.localdomain> (raw)
In-Reply-To: <20030529151424.GA1397@us.ibm.com>
On Thu, 29 May 2003, Paul E. McKenney wrote:
> On Fri, May 23, 2003 at 11:42:02AM -0700, Paul E. McKenney wrote:
> >
> > Exactly -- allows a ->nopage() to drop some lock to avoid races
> > between pagefault and either vmtruncate() or invalidate_mmap_range().
> > This race (from the cross-host mmap viewpoint) is described in:
> >
> > http://marc.theaimsgroup.com/?l=linux-kernel&m=105286345316249&w=2
>
> Rediffed for 2.5.70-mm1.
Me? I much preferred your original, much sparer, nopagedone patch
(labelled "uglyh as hell" by hch). I dislike passing lots of args
down a level so they can be passed up again to the library function.
In particular, I feel queasy (fear loss of control) about passing a
pmd_t* down to a filesystem, which I'd prefer to have no access to
such. But I may be in a minority, and the decision won't be mine.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"aart@kvack.org"> aart@kvack.org </a>
next prev parent reply other threads:[~2003-05-29 16:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-05-23 18:42 Paul E. McKenney
2003-05-29 15:14 ` Paul E. McKenney
2003-05-29 15:18 ` [RFC][PATCH] Remove LINUX_2_2 Paul E. McKenney
2003-05-29 16:33 ` Hugh Dickins [this message]
2003-05-29 17:15 ` [RFC][PATCH] Avoid vmtruncate/mmap-page-fault race Daniel Phillips
2003-05-29 17:39 ` Daniel Phillips
2003-05-29 20:24 ` Paul E. McKenney
2003-05-30 2:38 ` Paul E. McKenney
-- strict thread matches above, loose matches on Subject: below --
2003-05-17 18:21 [RFC][PATCH] vm_operation to avoid pagefault/inval race Daniel Phillips
2003-05-17 19:49 ` Andrew Morton
2003-05-20 1:23 ` Paul E. McKenney
2003-05-20 8:11 ` Andrew Morton
2003-05-23 14:35 ` [RFC][PATCH] Avoid vmtruncate/mmap-page-fault race Paul E. McKenney
2003-05-23 16:21 ` Hugh Dickins
2003-05-23 17:10 ` Daniel Phillips
2003-05-23 17:47 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.44.0305291723310.1800-100000@localhost.localdomain \
--to=hugh@veritas.com \
--cc=akpm@digeo.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=paulmck@us.ibm.com \
--cc=phillips@arcor.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox