From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 22 Jul 2002 15:36:33 -0700 (MST) From: Craig Kulesa Subject: Re: [PATCH 2/2] move slab pages to the lru, for 2.5.27 In-Reply-To: <20020722222150.GF919@holomorphy.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: William Lee Irwin III Cc: Steven Cole , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Steven Cole , Ed Tomlinson List-ID: On Mon, 22 Jul 2002, William Lee Irwin III wrote: > The pte_chain mempool was ridiculously huge and the use of mempool for > this at all was in error. That's what I thoguht too -- but Steven tried making the pool 1/4th the size and it still failed. OTOH, he tried 2.5.27-rmap, which uses the *same mempool patch* and he had no problem with the monster 128KB allocation. Maybe it was all luck. :) I can't yet see anything in the slablru patch that has anything to do with it... On another note -- Steven did point out that the slablru patch has a patchbug with regards to dquot.c. I think this error is also in Ed's June 5th patch (at least as posted), and I didn't catch it. I believe that: shrink_dqcache_memory(int priority, unsigned int gfp_mask) needs to be age_dqcache_memory(kmem_cache_t *cachep, int entries, int gfp_mask) in dquot.c. It'll be tested and fixed on the next go. :) Best regards, Craig Kulesa -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/