From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 25 Feb 2002 23:07:51 -0300 (BRT) From: Rik van Riel Subject: Re: [PATCH] struct page shrinkage In-Reply-To: <20020225.180122.120462472.davem@redhat.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: "David S. Miller" Cc: marcelo@conectiva.com.br, linux-mm@kvack.org, linux-kernel@vger.kernel.org List-ID: On Mon, 25 Feb 2002, David S. Miller wrote: > From: Rik van Riel > On Mon, 25 Feb 2002, David S. Miller wrote: > > > Please fix the atomic_t assumptions in init_page_count() first. > > You should be using atomic_set(...). > > Why ? You'll see init_page_count() is _only_ used from > free_area_init_core(), when nothing else is using the VM > yet. > > Rik, not every architecture has a "counter" member of > atomic_t, that is the problem. This is a hard bug, please > fix it. It is an opaque type, accessing its' implementation > directly is therefore illegal in the strongest way possible. OK, agreed. I'm making a new patch right now. regards, Rik -- "Linux holds advantages over the single-vendor commercial OS" -- Microsoft's "Competing with Linux" document http://www.surriel.com/ http://distro.conectiva.com/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/