From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 19 Feb 2002 07:38:02 -0300 (BRT) From: Rik van Riel Subject: Re: [PATCH] reduce struct_page size In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Linus Torvalds Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Mon, 18 Feb 2002, Linus Torvalds wrote: > On Mon, 18 Feb 2002, Rik van Riel wrote: > > > > o page->zone is shrunk from a pointer to an index into a small > > array of zones ... this means we have space for 3 more chars > > in the struct page to other stuff (say, page->age) > > Why not put "page->zone" into the page flags instead? The original reason it's not in page->flags is that the rmap patch also has page->age. Furthermore, the NUMA folks wanted the ability to have quite a few zones. > The patch looks good, it's just silly to say that you made "struct page" > smaller, and then waste four bytes. If you want I'll look into shoving the zone bits into page->flags ... regards, Rik -- "Linux holds advantages over the single-vendor commercial OS" -- Microsoft's "Competing with Linux" document http://www.surriel.com/ http://distro.conectiva.com/ -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/