Re: [PATCH *] rmap VM, version 12

[Rik van Riel <riel@conectiva.com.br>]

On Wed, 23 Jan 2002, David S. Miller wrote:

>    From: Rik van Riel <riel@conectiva.com.br>
>    Date: Wed, 23 Jan 2002 15:14:42 -0200 (BRST)
>
>      - use fast pte quicklists on non-pae machines           (Andrea Arcangeli)
>
> Does this work on SMP?  I remember they were turned off because
> they were simply broken on SMP.
>
> The problem is that when vmalloc() or whatever kernel mappings change
> you have to update all the quicklist page tables to match.

Actually, this is just using the pte_free_fast() and
{get,free}_pgd_fast() functions on non-pae machines.

I think this should be safe, unless there is a way
we could pagefault from inside interrupts (but I don't
think we do that).

OTOH, the -preempt people will want to add preemption
protection from the fiddling with the local pte freelist ;)

> Andrea probably fixed this, I haven't looked at the patch.
> If so, ignoreme.

He doesn't seem to fix anything other than just switching
on these options, but I guess this is safe since it's with
the 00_ series of patches in -aa.

(I don't have good experiences with 20_highmem-debug-8,
with that patch in the system plain doesn't boot ;))

regards,

Rik
-- 
"Linux holds advantages over the single-vendor commercial OS"
    -- Microsoft's "Competing with Linux" document

http://www.surriel.com/		http://distro.conectiva.com/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/