From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Wed, 15 Aug 2001 20:38:56 -0300 (BRST) From: Rik van Riel Subject: Re: 0-order allocation problem In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Hugh Dickins Cc: Linus Torvalds , Marcelo Tosatti , linux-mm@kvack.org List-ID: On Thu, 16 Aug 2001, Hugh Dickins wrote: > 1. Why test free_shortage() in the high-order case? The caller has > asked for a high-order allocation, and is prepared to wait: we > haven't found what the caller needs yet, we certainly should not > wait forever, but we should try harder: it's irrelevant whether > there's a free shortage or not - we've found a contiguity shortage. It may be irrelevant, but remember that try_to_free_pages() doesn't free any pages if there is no free shortage. Besides, even if it did chances are you wouldn't be able to allocate that 2MB contiguous area any time next week ;) > 3. Allocation failure message would do well to show gfp_mask too. Agreed, gfp_mask and PF_MEMALLOC would be useful things to know here... regards, Rik -- IA64: a worthy successor to i860. http://www.surriel.com/ http://distro.conectiva.com/ Send all your spam to aardvark@nl.linux.org (spam digging piggy) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/