From: Rik van Riel <riel@conectiva.com.br>
To: Hugh Dickins <hugh@veritas.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
linux-mm@kvack.org
Subject: Re: 0-order allocation problem
Date: Wed, 15 Aug 2001 20:38:56 -0300 (BRST) [thread overview]
Message-ID: <Pine.LNX.4.33L.0108152036040.5646-100000@imladris.rielhome.conectiva> (raw)
In-Reply-To: <Pine.LNX.4.21.0108152343460.972-100000@localhost.localdomain>
On Thu, 16 Aug 2001, Hugh Dickins wrote:
> 1. Why test free_shortage() in the high-order case? The caller has
> asked for a high-order allocation, and is prepared to wait: we
> haven't found what the caller needs yet, we certainly should not
> wait forever, but we should try harder: it's irrelevant whether
> there's a free shortage or not - we've found a contiguity shortage.
It may be irrelevant, but remember that try_to_free_pages()
doesn't free any pages if there is no free shortage.
Besides, even if it did chances are you wouldn't be able
to allocate that 2MB contiguous area any time next week ;)
> 3. Allocation failure message would do well to show gfp_mask too.
Agreed, gfp_mask and PF_MEMALLOC would be useful things
to know here...
regards,
Rik
--
IA64: a worthy successor to i860.
http://www.surriel.com/ http://distro.conectiva.com/
Send all your spam to aardvark@nl.linux.org (spam digging piggy)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2001-08-15 23:38 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.21.0108152049100.973-100000@localhost.localdomain>
2001-08-15 20:45 ` Linus Torvalds
2001-08-15 20:55 ` Marcelo Tosatti
2001-08-15 22:30 ` Linus Torvalds
2001-08-15 22:34 ` Rik van Riel
2001-08-15 23:27 ` Hugh Dickins
2001-08-15 22:15 ` Marcelo Tosatti
2001-08-15 22:00 ` Rik van Riel
2001-08-15 22:15 ` Rik van Riel
2001-08-15 23:09 ` Hugh Dickins
2001-08-15 21:54 ` Marcelo Tosatti
2001-08-15 23:38 ` Rik van Riel [this message]
2001-08-16 0:07 ` Hugh Dickins
2001-08-15 22:44 ` Marcelo Tosatti
2001-08-16 0:50 ` Linus Torvalds
2001-08-16 8:30 ` Daniel Phillips
2001-08-16 10:26 ` Stephen C. Tweedie
2001-08-16 12:18 ` Daniel Phillips
2001-08-16 15:35 ` Eric W. Biederman
2001-08-16 16:37 ` Stephen C. Tweedie
2001-08-17 3:20 ` Eric W. Biederman
2001-08-17 11:45 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33L.0108152036040.5646-100000@imladris.rielhome.conectiva \
--to=riel@conectiva.com.br \
--cc=hugh@veritas.com \
--cc=linux-mm@kvack.org \
--cc=marcelo@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox