From: Rik van Riel <riel@conectiva.com.br>
To: Daniel Phillips <phillips@bonn-fries.net>
Cc: linux-mm@kvack.org, Marcelo Tosatti <marcelo@conectiva.com.br>
Subject: Re: [RFC] Accelerate dbench
Date: Sat, 4 Aug 2001 21:02:53 -0300 (BRST) [thread overview]
Message-ID: <Pine.LNX.4.33L.0108042101341.2526-100000@imladris.rielhome.conectiva> (raw)
In-Reply-To: <01080502045901.00315@starship>
On Sun, 5 Aug 2001, Daniel Phillips wrote:
> --- ../2.4.7.clean/mm/filemap.c Sat Aug 4 14:27:16 2001
> +++ ./mm/filemap.c Sat Aug 4 14:32:51 2001
> - /* Mark the page referenced, kswapd will find it later. */
> SetPageReferenced(page);
> -
> + if (!PageActive(page))
> + activate_page(page);
I think this is wrong.
By doing this the page will end up at the far end
of the active list with the referenced bit already
set.
This doesn't allow us to distinguish between pages
which get accessed again after we put them on the
active list and pages which aren't.
Also, it effectively gives a double boost for this
one access...
regards,
Rik
--
Virtual memory is like a game you can't win;
However, without VM there's truly nothing to lose...
http://www.surriel.com/ http://distro.conectiva.com/
Send all your spam to aardvark@nl.linux.org (spam digging piggy)
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2001-08-05 0:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-08-05 0:04 Daniel Phillips
2001-08-05 0:02 ` Rik van Riel [this message]
2001-08-05 2:33 ` Daniel Phillips
2001-08-05 2:39 ` Rik van Riel
2001-08-06 17:20 ` Daniel Phillips
2001-08-06 0:28 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33L.0108042101341.2526-100000@imladris.rielhome.conectiva \
--to=riel@conectiva.com.br \
--cc=linux-mm@kvack.org \
--cc=marcelo@conectiva.com.br \
--cc=phillips@bonn-fries.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox