Re: strange locking __find_get_swapcache_page()

[Rik van Riel <riel@conectiva.com.br>]

On Mon, 30 Jul 2001, Linus Torvalds wrote:
> On Mon, 30 Jul 2001, Rik van Riel wrote:
> >
> > I've encountered a suspicious piece of code in filemap.c:
> >
> > struct page * __find_get_swapcache_page( ... )
>
> Hmm. I thin the whole PageSwapCache() test is bogus - if we
> found it on the swapper_space address space, then the page had
> better be a swap-cache page, and testing for it explicitly is
> silly.

*nod*

> Also, it appears that the only caller of this is
> find_get_swapcache_page(), which in itself really doesn't even

It's even simpler than that.  The only user is lookup_swap_cache(),
which is used only to see if a page is present in the swap cache
or not ...

regards,

Rik
--
Executive summary of a recent Microsoft press release:
   "we are concerned about the GNU General Public License (GPL)"


		http://www.surriel.com/
http://www.conectiva.com/	http://distro.conectiva.com/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/