From: Linus Torvalds <torvalds@transmeta.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-mm@kvack.org
Subject: Re: [PATCH] vmap_pages() (4th resend)
Date: Mon, 29 Jul 2002 12:25:24 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.33.0207291222440.11377-100000@penguin.transmeta.com> (raw)
In-Reply-To: <20020729211558.A4299@lst.de>
On Mon, 29 Jul 2002, Christoph Hellwig wrote:
>
> The old vmalloc_area_pages is renamed to __vmap_area_pages and
> vmalloc_area_pages is a small wrapper around it, passing in an NULL page
> array. Similarly __vmalloc is renamed to vmap_pages and a small wrapper
> is added.
I don't like the NULL page array.
I think vmalloc() should just allocate the pages and create the page
array, and vmap_pages() should never check for NULL. Ok?
That way, you can also get rid of passing in the gfp_mask, since that is
now entirely in the callers.
Linus
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2002-07-29 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-29 19:15 Christoph Hellwig
2002-07-29 19:25 ` Linus Torvalds [this message]
2002-07-29 19:46 ` Christoph Hellwig
2002-07-29 20:59 ` Linus Torvalds
2002-07-29 21:29 ` Christoph Hellwig
2002-08-05 17:42 ` Christoph Hellwig
2002-08-05 18:11 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.33.0207291222440.11377-100000@penguin.transmeta.com \
--to=torvalds@transmeta.com \
--cc=hch@lst.de \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox