Re: [PATCH] documentation mm.h + swap.h

[Rik van Riel <riel@conectiva.com.br>]

On Fri, 9 Mar 2001, Philipp Rumpf wrote:
> On Thu, Mar 08, 2001 at 06:10:16PM -0300, Rik van Riel wrote:
> > --- linux-2.4.2-doc/include/linux/mm.h.orig	Wed Mar  7 15:36:32 2001
> > +++ linux-2.4.2-doc/include/linux/mm.h	Thu Mar  8 09:54:22 2001
> > @@ -39,32 +39,37 @@
> >   * library, the executable area etc).
> >   */
> >  struct vm_area_struct {
> > -	struct mm_struct * vm_mm;	/* VM area parameters */
> > -	unsigned long vm_start;
> > -	unsigned long vm_end;
> > +	struct mm_struct * vm_mm;	/* The address space we belong to. */
> > +	unsigned long vm_start;		/* Our start address within vm_mm. */
> > +	unsigned long vm_end;		/* Our end address within vm_mm. */
>
> it might be a good idea to point out that this is the address of
> the byte after the last one covered by the vma, not the address
> of the last byte.

        unsigned long vm_end;           /* The first byte after our end address
                                           within vm_mm. */

Does this look good to you ?


> (are there any architectures where we allow a vma at the end of
> memory ?  Is the mm/ code handling ->vm_end = 0 correctly ?)

Good question ...

> >  /*
> > + * Each physical page in the system has a struct page associated with
             ^^^^^^^^
> Each page of "real" RAM.

> > + *
> > + * TODO: make this structure smaller, it could be as small as 32 bytes.
>
> Or make it cover large pages, which might be even more of a win ..

*nod*

regards,

Rik
--
Linux MM bugzilla: http://linux-mm.org/bugzilla.shtml

Virtual memory is like a game you can't win;
However, without VM there's truly nothing to lose...

		http://www.surriel.com/
http://www.conectiva.com/	http://distro.conectiva.com/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/