From: Hugh Dickins <hugh@veritas.com>
To: Andrew Morton <akpm@zip.com.au>
Cc: Christoph Hellwig <hch@caldera.de>,
Christoph Rohland <cr@sap.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
velco@fadata.bg
Subject: Re: [PATCH] updated radix-tree pagecache
Date: Tue, 26 Mar 2002 13:02:12 +0000 (GMT) [thread overview]
Message-ID: <Pine.LNX.4.21.0203261227570.1084-100000@localhost.localdomain> (raw)
In-Reply-To: <3CA045BC.AA75D788@zip.com.au>
On Tue, 26 Mar 2002, Andrew Morton wrote:
>
> Aside: This is not related to ratcache: shmem_getpage_locked() is
> setting PG_dirty but not adding the page to mapping->dirty_pages. Is
> this intended?
Yes. It used to be the case that if a tmpfs file page got on to
mapping->dirty_pages, fsync on that file would never escape from
filemap_fdatasync if there was no swap. Hence also "SetPageDirty"
in several places which originally said "set_page_dirty".
Nowadays the "if (!PageLaunder(page)) return fail_writepage(page);"
at the start of shmem_writepage would prevent that hang, and
prevents a subtler tmpfs file corruption we realized later on.
But the dirty_pages list is still a waste of time for tmpfs:
its data does not need to be committed to stable storage.
Hugh
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
prev parent reply other threads:[~2002-03-26 13:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-24 11:34 Christoph Hellwig
2002-03-26 9:56 ` Andrew Morton
2002-03-26 13:02 ` Hugh Dickins [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0203261227570.1084-100000@localhost.localdomain \
--to=hugh@veritas.com \
--cc=akpm@zip.com.au \
--cc=cr@sap.com \
--cc=hch@caldera.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=velco@fadata.bg \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox