linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo@conectiva.com.br>
To: Linus Torvalds <torvalds@transmeta.com>
Cc: lkml <linux-kernel@vger.kernel.org>, linux-mm@kvack.org
Subject: [PATCH] remove page_launder() from bdflush
Date: Tue, 15 May 2001 01:41:23 -0300 (BRT)	[thread overview]
Message-ID: <Pine.LNX.4.21.0105150134190.32493-100000@freak.distro.conectiva> (raw)

Hi Linus, 

There is no reason why bdflush should call page_launder().

Its pretty obvious that bdflush's job is to only write out _buffers_. 

Under my tests this patch makes things faster.

Guess why? Because bdflush is writing out buffers when it should instead
blocking inside try_to_free_pages().

Please apply. 

--- fs/buffer.c.orig    Tue May 15 03:13:05 2001
+++ fs/buffer.c Tue May 15 03:13:22 2001
@@ -2703,8 +2703,6 @@
                CHECK_EMERGENCY_SYNC
 
                flushed = flush_dirty_buffers(0);
-               if (free_shortage())
-                       flushed += page_launder(GFP_KERNEL, 0);
 
                /*
                 * If there are still a lot of dirty buffers around,


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

             reply	other threads:[~2001-05-15  4:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-05-15  4:41 Marcelo Tosatti [this message]
2001-05-15 10:05 ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0105150134190.32493-100000@freak.distro.conectiva \
    --to=marcelo@conectiva.com.br \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox