From: Rik van Riel <riel@conectiva.com.br>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Ben LaHaise <bcrl@redhat.com>, Christoph Rohland <cr@sap.com>
Subject: Re: [PATCH] Fix races in 2.4.2-ac22 SysV shared memory
Date: Sat, 24 Mar 2001 22:05:18 -0300 (BRST) [thread overview]
Message-ID: <Pine.LNX.4.21.0103242203290.1863-100000@imladris.rielhome.conectiva> (raw)
In-Reply-To: <20010325001338.C11686@redhat.com>
On Sun, 25 Mar 2001, Stephen C. Tweedie wrote:
> Rik, do you think it is really necessary to take the page lock and
> release it inside lookup_swap_cache? I may be overlooking something,
> but I can't see the benefit of it ---
I don't think we need to do this, except to protect us from
using a page which isn't up-to-date yet and locked because
of disk IO.
Reclaim_page() takes the pagecache_lock before trying to
free anything, so there's no reason to lock against that.
regards,
Rik
--
Virtual memory is like a game you can't win;
However, without VM there's truly nothing to lose...
http://www.surriel.com/
http://www.conectiva.com/ http://distro.conectiva.com.br/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2001-03-25 1:27 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-03-23 1:13 Stephen C. Tweedie
2001-03-23 19:58 ` Linus Torvalds
2001-03-23 22:20 ` Alan Cox
2001-03-23 22:23 ` Alexander Viro
2001-03-23 22:29 ` Alan Cox
2001-03-23 22:27 ` Linus Torvalds
2001-03-23 22:35 ` Alan Cox
2001-03-23 22:37 ` Linus Torvalds
2001-03-23 22:31 ` David S. Miller
2001-03-25 0:13 ` Stephen C. Tweedie
2001-03-25 1:05 ` Rik van Riel [this message]
2001-03-25 16:50 ` Stephen C. Tweedie
2001-03-28 9:18 ` Christoph Rohland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0103242203290.1863-100000@imladris.rielhome.conectiva \
--to=riel@conectiva.com.br \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bcrl@redhat.com \
--cc=cr@sap.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sct@redhat.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox