From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 13 Feb 2001 00:05:50 -0200 (BRST) From: Marcelo Tosatti Subject: Re: [PATCH] guard mm->rss with page_table_lock (241p11) In-Reply-To: <3A88A6ED.6B51BCA9@mvista.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: george anzinger Cc: Rasmus Andersen , Rik van Riel , torvalds@transmeta.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org List-ID: On Mon, 12 Feb 2001, george anzinger wrote: > Excuse me if I am off base here, but wouldn't an atomic operation be > better here. There are atomic inc/dec and add/sub macros for this. It > just seems that that is all that is needed here (from inspection of the > patch). Most functions which touch mm->rss already hold mm->page_table_lock (also this functions are called more often and they use more CPU). Making those functions use an atomic instruction just to optimize the functions which do not lock mm->page_table_lock is not a good tradeoff. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/