linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo@conectiva.com.br>
To: george anzinger <george@mvista.com>
Cc: Rasmus Andersen <rasmus@jaquet.dk>,
	Rik van Riel <riel@conectiva.com.br>,
	torvalds@transmeta.com, linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] guard mm->rss with page_table_lock (241p11)
Date: Tue, 13 Feb 2001 00:05:50 -0200 (BRST)	[thread overview]
Message-ID: <Pine.LNX.4.21.0102122334240.29855-100000@freak.distro.conectiva> (raw)
In-Reply-To: <3A88A6ED.6B51BCA9@mvista.com>


On Mon, 12 Feb 2001, george anzinger wrote:

> Excuse me if I am off base here, but wouldn't an atomic operation be
> better here.  There are atomic inc/dec and add/sub macros for this.  It
> just seems that that is all that is needed here (from inspection of the
> patch).

Most functions which touch mm->rss already hold mm->page_table_lock (also
this functions are called more often and they use more CPU).

Making those functions use an atomic instruction just to optimize the
functions which do not lock mm->page_table_lock is not a good tradeoff.


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

  reply	other threads:[~2001-02-13  2:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-29 21:23 Rasmus Andersen
2001-01-29 21:30 ` Rik van Riel
2001-01-29 21:43   ` Rasmus Andersen
2001-01-29 21:47     ` Rik van Riel
2001-01-30  8:18     ` David Howells
2001-01-30  8:31       ` Rasmus Andersen
2001-01-30 14:32         ` Mark Hahn
2001-01-30 15:30           ` Eric W. Biederman
2001-01-30  8:39       ` David S. Miller
2001-01-30 11:17         ` Chris Wedgwood
2001-01-30 11:23           ` Rik van Riel
2001-01-30 11:38             ` Rasmus Andersen
2001-02-13  3:15     ` george anzinger
2001-02-13  2:05       ` Marcelo Tosatti [this message]
2001-02-13 10:08       ` Stephen C. Tweedie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0102122334240.29855-100000@freak.distro.conectiva \
    --to=marcelo@conectiva.com.br \
    --cc=george@mvista.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=rasmus@jaquet.dk \
    --cc=riel@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox