From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Sun, 14 Jan 2001 10:57:30 -0200 (BRST) From: Marcelo Tosatti Subject: Re: [patch] mm-deactivate-fix-1 In-Reply-To: <87ofxaz1y0.fsf@atlas.iskon.hr> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Zlatko Calusic Cc: linux-mm@kvack.org List-ID: On 14 Jan 2001, Zlatko Calusic wrote: > I have noticed that in deactivate_page_nolock() function pages get > unconditionally moved from the active to the inact_dirty list. Even if > it is really easy with additional check to put them straight to the > inact_clean list if they're freeable. That keeps the list statistics > more accurate and in the end should result in a little bit less CPU > cycles burned (only one list transition, less locking). As a bonus, > the comment above the function is now correct. :) > > I have tested the patch thoroughly and couldn't find any problems with > it. It should be really safe as reclaim_page() already carefully > checks pages before freeing. > > Comments? We want to move all deactivated pages to the inactive dirty list to get FIFO behaviour while reclaiming them. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/