From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 8 Jan 2001 21:49:44 -0200 (BRST) From: Marcelo Tosatti Subject: Re: Subtle MM bug In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-linux-mm@kvack.org Return-Path: To: Linus Torvalds Cc: "Stephen C. Tweedie" , "David S. Miller" , Rik van Riel , linux-mm@kvack.org List-ID: On Mon, 8 Jan 2001, Linus Torvalds wrote: > > On Mon, 8 Jan 2001, Marcelo Tosatti wrote: > > > > I've removed the free_shortage() of refill_inactive() in the patch. > > > > Comments are welcome. > > One comment: why does refill_inactive() do the shrink_dcache_memory() at > all? Why not just remove that? > > do_try_to_free_pages() will do that, and that's where it makes more sense > (shrinking the dcache/icache has absolutely nothing to do with the > inactive list). Right. kmem_cache_reap() should not be there too. > Also, we should probably remove the "made_progress" and "count--" from the > swap_out() case, as swap_out() hasn't actually caused pages to be free'd > in a long time.. Indeed. Your lazy enough to ask me to regenerate a patch or you can by yourself? :) -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/