Re: [patch] mm-cleanup-1 (2.4.0)

[Rik van Riel <riel@conectiva.com.br>]

On 7 Jan 2001, Zlatko Calusic wrote:

> The following patch cleans up some obsolete structures from the
> mm & proc code.
> 
> Beside that it also fixes what I think is a bug:
> 
>         if ((rw == WRITE) && atomic_read(&nr_async_pages) >
>                        pager_daemon.swap_cluster * (1 << page_cluster))
> 
> In that (swapout logic) it effectively says swap out 512KB at
> once (at least on my memory configuration). I think that is a
> little too much.

Since we submit a whole cluster of (1 << page_cluster)
size at once, your change would mean that the VM can
only do one IO at a time...

Have you actually measured your changes or is it just
a gut feeling that the current default is too much?

(I can agree with 1/2 MB being a bit much, but doing
just one IO at a time is probably wrong too...)


The cleanup part of your patch is nice. I think that
one should be submitted as soon as the 2.4 bugfix
period is over ...

(and yes, I'm not submitting any of my own trivial
patches either unless they're REALLY needed, lets make
sure Linus has enough time to focus on the real bugfixes)

regards,

Rik
--
Virtual memory is like a game you can't win;
However, without VM there's truly nothing to lose...

		http://www.surriel.com/
http://www.conectiva.com/	http://distro.conectiva.com.br/

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/