linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo@conectiva.com.br>
To: Rik van Riel <riel@conectiva.com.br>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH *] 2.4.0 VM improvements
Date: Sun, 7 Jan 2001 14:25:42 -0200 (BRST)	[thread overview]
Message-ID: <Pine.LNX.4.21.0101071422180.4416-100000@freak.distro.conectiva> (raw)
In-Reply-To: <Pine.LNX.4.21.0101071529070.21675-100000@duckman.distro.conectiva>


On Sun, 7 Jan 2001, Rik van Riel wrote:

> The patch is available at this URL:
> 
> 	http://www.surriel.com/patches/2.4/2.4.0-tunevm+rss

I have one improvement on top of your patch.

Now its not more "rare" (as the comment on the code stated) to have
pages with page->age == 0 being called on lru_cache_add. 

This patch should make the overhead of calling lru_cache_add on pages with
page->age == 0 smaller. 

--- mm/swap.c.orig      Sun Jan  7 15:59:37 2001
+++ mm/swap.c   Sun Jan  7 16:11:21 2001
@@ -233,10 +233,12 @@
        if (!PageLocked(page))
                BUG();
        DEBUG_ADD_PAGE
-       add_page_to_active_list(page);
-       /* This should be relatively rare */
-       if (!page->age)
-               deactivate_page_nolock(page);
+
+       if (page->age)
+               add_page_to_active_list(page);
+       else
+               add_page_to_inactive_dirty_list(page);
+
        spin_unlock(&pagemap_lru_lock);
 }
 


--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

      reply	other threads:[~2001-01-07 16:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-01-07 17:35 Rik van Riel
2001-01-07 16:25 ` Marcelo Tosatti [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.21.0101071422180.4416-100000@freak.distro.conectiva \
    --to=marcelo@conectiva.com.br \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@conectiva.com.br \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox