From: Ingo Molnar <mingo@redhat.com>
To: Stephen Tweedie <sct@redhat.com>
Cc: Ben LaHaise <bcrl@redhat.com>,
torvalds@transmeta.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [RFC] atomic pte updates and pae changes, take 2
Date: Sun, 15 Oct 2000 08:01:14 -0400 (EDT) [thread overview]
Message-ID: <Pine.LNX.4.21.0010150800250.30587-100000@devserv.devel.redhat.com> (raw)
In-Reply-To: <20001014143309.D5813@redhat.com>
On Sat, 14 Oct 2000, Stephen Tweedie wrote:
> Looks good. The only trouble I can see left is that pte_clear() is
> still using set_pte(), which doesn't work right for PAE36. set_pte()
> is setting the high word first, which is fine for installing a new
> pte, but if you do that to clear a pte then you have left the old
> page-present bit intact while you've removed have of the pte.
> pte_clear() needs to clear the words in the other order (just as
> pte_get_and_clear correctly does).
yep, that should make it work. The pgd operations must use 64-bit
instructions - the pmds are fine to be 64-bit for the time being, but they
can be changed to the pte logic as well.
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-10-15 12:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-14 0:17 Ben LaHaise
2000-10-14 1:43 ` Linus Torvalds
2000-10-14 8:26 ` David S. Miller
2000-10-15 12:07 ` Ingo Molnar
2000-10-14 13:33 ` Stephen Tweedie
2000-10-15 12:01 ` Ingo Molnar [this message]
2000-10-19 20:16 ` oopses in test10-pre4 (was Re: [RFC] atomic pte updates and pae changes, take 3) Linus Torvalds
2000-10-20 5:44 ` Ben LaHaise
2000-10-20 17:18 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0010150800250.30587-100000@devserv.devel.redhat.com \
--to=mingo@redhat.com \
--cc=bcrl@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sct@redhat.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox