From: Ingo Molnar <mingo@elte.hu>
To: Rik van Riel <riel@conectiva.com.br>,
Roger Larsson <roger.larsson@norran.net>
Cc: Linus Torvalds <torvalds@transmeta.com>,
MM mailing list <linux-mm@kvack.org>,
linux-kernel@vger.kernel.org
Subject: refill_inactive()
Date: Sun, 24 Sep 2000 11:57:48 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.21.0009241148100.2789-100000@elte.hu> (raw)
i'm wondering about the following piece of code in refill_inactive():
if (current->need_resched && (gfp_mask & __GFP_IO)) {
__set_current_state(TASK_RUNNING);
schedule();
}
shouldnt this be __GFP_WAIT? It's true that __GFP_IO implies __GFP_WAIT
(because IO cannot be done without potentially scheduling), so the code is
not buggy, but the above 'yielding' of the CPU should be done in the
GFP_BUFFER case as well. (which is __GFP_WAIT but not __GFP_IO)
Objections?
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next reply other threads:[~2000-09-24 9:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-09-24 9:57 Ingo Molnar [this message]
2000-09-24 10:15 ` refill_inactive() Arjan van de Ven
2000-09-24 10:56 ` refill_inactive() Ingo Molnar
2000-09-25 14:06 ` refill_inactive() Rik van Riel
2000-09-25 14:35 ` refill_inactive() Ingo Molnar
2000-09-25 16:08 ` refill_inactive() Rik van Riel
2000-09-25 16:17 ` refill_inactive() Linus Torvalds
2000-09-25 16:33 ` refill_inactive() Rik van Riel
2000-09-25 17:45 ` refill_inactive() Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.21.0009241148100.2789-100000@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=roger.larsson@norran.net \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox